fix(consilium): no merge gate for a publish-failed dev round - #578
Merged
Conversation
A dev close-out that ERRORED without producing a PR (e.g. the branch
push was rejected by a server-side policy hook) parks in awaiting_merge
so the human sees the error — but the UI still offered 'Approve merge &
continue' with nothing to merge, and the route would happily transition
as if the round had shipped.
- route: merge-approved returns 409 ('failed to publish') when the loop
has an error and no prRef. Research loops (prRef null, NO error) keep
their approve-and-continue gate.
- UI: the approve button is suppressed in that state and a
'Publish failed — nothing to merge' callout explains what happened and
that the round branch is intact.
loop-routes integration: 20 passed (1 new). tsc + vite build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
Dev-раунд, у которого push/MR отклонён (например, pre-receive policy hook), паркуется в
awaiting_merge«чтобы человек увидел ошибку» — но UI безусловно показывал Approve merge & continue, а роут охотно делал переход, как будто раунд отгружен. Мержить при этом нечего:prRef = null.Фикс
merge-approved→ 409nothing to merge — the develop round failed to publishприerror && !prRef. Research-лупы (prRef nullБЕЗ error) сохраняют свой легитимный гейт.Тесты
loop-routes integration: 20 passed (+1 новый кейс). tsc + vite build чистые.